On Sun, Nov 07, 2021 at 12:03:04PM +0000, Eiichi Tsukata wrote:
Currently vosck_connect() increments sock refcount for nonblocking
socket each time it's called, which can lead to memory leak if
it's called multiple times because connect timeout function decrements
sock refcount only once.
Fixes it by making vsock_connect() return -EALREADY immediately when
sock state is already SS_CONNECTING.
Signed-off-by: Eiichi Tsukata <eiichi.tsukata@xxxxxxxxxxx>
---
net/vmw_vsock/af_vsock.c | 2 ++
1 file changed, 2 insertions(+)
Make sense to me, thanks for fixing this issue!
I think would be better to add the Fixes ref in the commit message:
Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
With that:
Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
Thanks,
Stefano
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
