RE: [PATCH linux-next v5 7/8] vdpa/mlx5: Support configuration of MAC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> From: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Sent: Tuesday, October 26, 2021 2:45 AM
> 
> On Mon, Oct 25, 2021 at 06:35:35PM +0000, Parav Pandit wrote:
> >
> > > From: Parav Pandit <parav@xxxxxxxxxx>
> > > Sent: Monday, October 25, 2021 6:23 PM
> > >
> > > From: Eli Cohen <elic@xxxxxxxxxx>
> > >
> > > Add code to accept MAC configuration through vdpa tool. The MAC is
> > > written into the config struct and later can be retrieved through
> get_config().
> > >
> > > Examples:
> > > 1. Configure MAC while adding a device:
> > > $ vdpa dev add mgmtdev pci/0000:06:00.2 name vdpa0 mac
> > > 00:11:22:33:44:55
> > >
> > > 2. Show configured params:
> > > $ vdpa dev config show
> > > vdpa0: mac 00:11:22:33:44:55 link down link_announce false
> > > max_vq_pairs 8 mtu 1500
> > >
> > > Signed-off-by: Eli Cohen <elic@xxxxxxxxxx>
> > > Reviewed-by: Parav Pandit <parav@xxxxxxxxxx>
> > > Acked-by: Jason Wang <jasowang@xxxxxxxxxx>
> > > ---
> > >  drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 ++++++++++-------
> > >  1 file changed, 10 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > index 8d1539728a59..860d80efa5d1 100644
> > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > @@ -6,6 +6,7 @@
> > >  #include <linux/vringh.h>
> > >  #include <uapi/linux/virtio_net.h>
> > >  #include <uapi/linux/virtio_ids.h>
> > > +#include <uapi/linux/vdpa.h>
> > >  #include <linux/virtio_config.h>
> > >  #include <linux/auxiliary_bus.h>
> > >  #include <linux/mlx5/cq.h>
> > > @@ -2523,18 +2524,19 @@ static int mlx5_vdpa_dev_add(struct
> > > vdpa_mgmt_dev *v_mdev, const char *name,
> > >  	if (err)
> > >  		goto err_mtu;
> > >
> > > -	ndev->config.mtu = cpu_to_mlx5vdpa16(mvdev, mtu);
> > I messed up above line in the rebase conflict.
> > Let me resend the series.
> 
> If it's happening it's better happen soon, rc7 is out.
> 
Done at [1].
[1] https://lore.kernel.org/virtualization/20211026040243.79005-1-parav@xxxxxxxxxx/T/#t
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization



[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux