On Thu, Aug 19, 2021 at 4:15 PM Eli Cohen <elic@xxxxxxxxxx> wrote: > > On Thu, Aug 19, 2021 at 10:48:19AM +0300, Eli Cohen wrote: > > On Thu, Aug 19, 2021 at 03:41:52PM +0800, Jason Wang wrote: > > > > > > 在 2021/8/19 下午3:24, Eli Cohen 写道: > > > > > > > > + vringh_set_iotlb(&mvdev->cvq.vring, mvdev->cvq.iotlb, &mvdev->cvq.iommu_lock); > > > > > > > > + err = iova_cache_get(); > > > > > > > Any reason for using iova cache here? > > > > > > Isn't it required? Aren't we allocating buffers for the CVQ from > > > > > > iommu_iova kmem cache? > > > > > I may miss something here but which buffer did you refer here? > > > > > > > > > Aren't the data buffers for the control VQ allocated from this cache? > > > > > > > > > Sorry, but you mean the buffer managed by the virtio-net or the mlx5e here? > > > > I assume both directions: virtio_net sends a control message and uses a > > a buffer to put information in. mlx5_vdpa responds and uses data buffer > > for the response. > > > > Is it not so? > > > > Seems like removing it does not hurt. > Will remove. Yes, my understanding is that it is only required if you're using the iova allocator. Thanks > > > > > > > Thanks > > > > > > > > > > > > > > _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
