On Thu, Aug 05, 2021 at 04:08:46PM +0800, Xianting Tian wrote: > > 在 2021/8/5 下午3:58, Jiri Slaby 写道: > > Hi, > > > > On 04. 08. 21, 4:54, Xianting Tian wrote: > > > @@ -933,6 +949,16 @@ struct hvc_struct *hvc_alloc(uint32_t vtermno, > > > int data, > > > hp->outbuf_size = outbuf_size; > > > hp->outbuf = &((char *)hp)[ALIGN(sizeof(*hp), sizeof(long))]; > > > + /* > > > + * hvc_con_outbuf is guaranteed to be aligned at least to the > > > + * size(N_OUTBUF) by kmalloc(). > > > + */ > > > + hp->hvc_con_outbuf = kzalloc(N_OUTBUF, GFP_KERNEL); > > > + if (!hp->hvc_con_outbuf) > > > + return ERR_PTR(-ENOMEM); > > > > This leaks hp, right? > > > > BTW your 2 patches are still not threaded, that is hard to follow. > > yes, thanks, I found the bug, I am preparing to do this in v4. > > It is the first time I send series patches(number >1), I checked the method > for sending series patch on LKML.org, I should send '0/2' which is the > history info for series patches. Please use 'git send-email' to send the full series all at once, otherwise it is hard to make the emails threaded "by hand" if you do not do so. thanks, greg k-h _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
