Re: [PATCH 1/1] virtio: disable partitions scanning for no partitions block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/07/21 11:47, Yury Kamenev wrote:
+#ifdef CONFIG_VIRTIO_BLK_NO_PART_SCAN
+	if (unlikely(partitions_scanning_disable))
+		/* disable partitions scanning if it was stated in virtio features*/
+		if (virtio_has_feature(vdev, VIRTIO_BLK_F_NO_PART_SCAN))
+			vblk->disk->flags |= GENHD_FL_NO_PART_SCAN;
+#endif
+

Has this been added to the spec? It doesn't seem like a good idea, as pointed out by Stefan[1], Christoph[2] and myself[3].

Paolo

[1] https://lore.kernel.org/linux-block/20210524145654.GA2632@xxxxxx/T/#m2697cb41578490aad49ed1d8fa6604bf0924b54d [2] https://lore.kernel.org/linux-block/20210524145654.GA2632@xxxxxx/T/#mc59329fd824102f94ac2f6b29fe94a652849aca0 [3] https://lore.kernel.org/linux-block/20210524145654.GA2632@xxxxxx/T/#mee6787c4fd87790b64feccc9e77fd5f618c2c336

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization



[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux