Re: [PATCH -next] ALSA: virtio: use module_virtio_driver() to simplify the code

[Anton Yakovlev <anton.yakovlev@xxxxxxxxxxxxxxx>]

On 08.04.2021 14:54, Chen Huang wrote
> module_virtio_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Chen Huang <chenhuang5@xxxxxxxxxx>

Thanks for the patch.

Reviewed-by: Anton Yakovlev <anton.yakovlev@xxxxxxxxxxxxxxx>

> ---
>   sound/virtio/virtio_card.c | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/sound/virtio/virtio_card.c b/sound/virtio/virtio_card.c
> index ae9128063917..150ab3e37013 100644
> --- a/sound/virtio/virtio_card.c
> +++ b/sound/virtio/virtio_card.c
> @@ -432,17 +432,7 @@ static struct virtio_driver virtsnd_driver = {
>   #endif
>   };
>
> -static int __init init(void)
> -{
> -       return register_virtio_driver(&virtsnd_driver);
> -}
> -module_init(init);
> -
> -static void __exit fini(void)
> -{
> -       unregister_virtio_driver(&virtsnd_driver);
> -}
> -module_exit(fini);
> +module_virtio_driver(virtsnd_driver);
>
>   MODULE_DEVICE_TABLE(virtio, id_table);
>   MODULE_DESCRIPTION("Virtio sound card driver");
> --
> 2.17.1

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization