On 2021/1/10 下午2:39, Eli Cohen wrote:
On Fri, Jan 08, 2021 at 04:24:43PM +0800, Jason Wang wrote:
Upstream: posted
When compiling with -Werror=maybe-uninitialized, gcc may complains the
possible uninitialized umem. Fix that.
Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index f1d54814db97..a6ad83d8d8e2 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -706,6 +706,9 @@ static void umem_destroy(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtqueue
case 3:
umem = &mvq->umem3;
break;
+ default:
+ WARN(1, "unsupported umem num %d\n", num);
+ return;
}
MLX5_SET(destroy_umem_in, in, opcode, MLX5_CMD_OP_DESTROY_UMEM);
Since the "default" case will never be executed, maybe it's better to
just change "case 3:" to "default:" and avoid the WARN().
Fine with me. Will do that in V3.
Thanks
--
2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
