On 29.12.20 03:44, Tian Tao wrote:
> Fixes coccicheck warnings:
> drivers/virtio/virtio_mem.c:2580:2-25: WARNING: Assignment of 0/1 to
> bool variable.
>
> Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>
> ---
> drivers/virtio/virtio_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index 9fc9ec4..85a272c 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -2577,7 +2577,7 @@ static int virtio_mem_probe(struct virtio_device *vdev)
> * actually in use (e.g., trying to reload the driver).
> */
> if (vm->plugged_size) {
> - vm->unplug_all_required = 1;
> + vm->unplug_all_required = true;
> dev_info(&vm->vdev->dev, "unplugging all memory is required\n");
> }
>
>
Thanks - the patch subject is a little weird ("false"). I suggest
"virtio-mem: use boolean value when setting vm->unplug_all_required"
Apart from that
Acked-by: David Hildenbrand <david@xxxxxxxxxx>
@Mst, do you want a resend or can you fixup the subject? Thanks!
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
