Re: [PATCH v10 75/81] KVM: introspection: add KVMI_VCPU_EVENT_PF

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Adalbert,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on dc924b062488a0376aae41d3e0a27dc99f852a5e]

url:    https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530
base:    dc924b062488a0376aae41d3e0a27dc99f852a5e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/e2e6aad169a874e4a2c4f4639c252f6b1d816d7b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Adalbert-Laz-r/VM-introspection/20201125-174530
        git checkout e2e6aad169a874e4a2c4f4639c252f6b1d816d7b
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c:481:5: warning: no previous prototype for 'kvmi_hook' [-Wmissing-prototypes]
     481 | int kvmi_hook(struct kvm *kvm, const struct kvm_introspection_hook *hook)
         |     ^~~~~~~~~
>> arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c:1076:6: warning: no previous prototype for 'kvmi_restricted_page_access' [-Wmissing-prototypes]
    1076 | bool kvmi_restricted_page_access(struct kvm_introspection *kvmi, gpa_t gpa,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/kvmi_restricted_page_access +1076 arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c

  1075	
> 1076	bool kvmi_restricted_page_access(struct kvm_introspection *kvmi, gpa_t gpa,
  1077					 u8 access)
  1078	{
  1079		u8 allowed_access;
  1080		int err;
  1081	
  1082		err = kvmi_get_gfn_access(kvmi, gpa_to_gfn(gpa), &allowed_access);
  1083		if (err)
  1084			return false;
  1085	
  1086		/*
  1087		 * We want to be notified only for violations involving access
  1088		 * bits that we've specifically cleared
  1089		 */
  1090		if (access & (~allowed_access))
  1091			return true;
  1092	
  1093		return false;
  1094	}
  1095	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux