Re: [PATCH v10 67/81] KVM: introspection: add KVMI_VCPU_GET_XSAVE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Adalbert,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on dc924b062488a0376aae41d3e0a27dc99f852a5e]

url:    https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530
base:    dc924b062488a0376aae41d3e0a27dc99f852a5e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/c8777a54e026a93f283f7dfac30ed2cb2563fd03
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Adalbert-Laz-r/VM-introspection/20201125-174530
        git checkout c8777a54e026a93f283f7dfac30ed2cb2563fd03
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   arch/x86/kvm/kvmi_msg.c: In function 'handle_vcpu_inject_exception':
   arch/x86/kvm/kvmi_msg.c:158:38: warning: variable 'arch' set but not used [-Wunused-but-set-variable]
     158 |  struct kvm_vcpu_arch_introspection *arch;
         |                                      ^~~~
   arch/x86/kvm/kvmi_msg.c: In function 'handle_vcpu_get_xsave':
>> arch/x86/kvm/kvmi_msg.c:202:11: warning: variable 'ec' set but not used [-Wunused-but-set-variable]
     202 |  int err, ec = 0;
         |           ^~

vim +/ec +202 arch/x86/kvm/kvmi_msg.c

   196	
   197	static int handle_vcpu_get_xsave(const struct kvmi_vcpu_msg_job *job,
   198					 const struct kvmi_msg_hdr *msg,
   199					 const void *req)
   200	{
   201		struct kvmi_vcpu_get_xsave_reply *rpl;
 > 202		int err, ec = 0;
   203	
   204		rpl = kvmi_msg_alloc();
   205		if (!rpl)
   206			ec = -KVM_ENOMEM;
   207		else
   208			kvm_vcpu_ioctl_x86_get_xsave(job->vcpu, &rpl->xsave);
   209	
   210		err = kvmi_msg_vcpu_reply(job, msg, 0, rpl, sizeof(*rpl));
   211	
   212		kvmi_msg_free(rpl);
   213		return err;
   214	}
   215	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux