Re: [PATCH v10 33/81] KVM: introspection: add hook/unhook ioctls

[kernel test robot <lkp@xxxxxxxxx>]

Hi "Adalbert,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on dc924b062488a0376aae41d3e0a27dc99f852a5e]

url:    https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530
base:    dc924b062488a0376aae41d3e0a27dc99f852a5e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/fa233c4711c43446c876e84ca6f87b702b0990a8
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Adalbert-Laz-r/VM-introspection/20201125-174530
        git checkout fa233c4711c43446c876e84ca6f87b702b0990a8
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c:90:6: warning: no previous prototype for 'kvmi_put' [-Wmissing-prototypes]
      90 | void kvmi_put(struct kvm *kvm)
         |      ^~~~~~~~
>> arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c:121:5: warning: no previous prototype for 'kvmi_hook' [-Wmissing-prototypes]
     121 | int kvmi_hook(struct kvm *kvm, const struct kvm_introspection_hook *hook)
         |     ^~~~~~~~~

vim +/kvmi_hook +121 arch/x86/kvm/../../../virt/kvm/introspection/kvmi.c

   120	
 > 121	int kvmi_hook(struct kvm *kvm, const struct kvm_introspection_hook *hook)
   122	{
   123		struct kvm_introspection *kvmi;
   124		int err = 0;
   125	
   126		mutex_lock(&kvm->kvmi_lock);
   127	
   128		if (kvm->kvmi) {
   129			err = -EEXIST;
   130			goto out;
   131		}
   132	
   133		kvmi = kvmi_alloc(kvm, hook);
   134		if (!kvmi) {
   135			err = -ENOMEM;
   136			goto out;
   137		}
   138	
   139		kvm->kvmi = kvmi;
   140	
   141		err = __kvmi_hook(kvm, hook);
   142		if (err)
   143			goto destroy;
   144	
   145		init_completion(&kvm->kvmi_complete);
   146	
   147		refcount_set(&kvm->kvmi_ref, 1);
   148	
   149		kvmi->recv = kthread_run(kvmi_recv_thread, kvmi, "kvmi-recv");
   150		if (IS_ERR(kvmi->recv)) {
   151			err = -ENOMEM;
   152			kvmi_put(kvm);
   153			goto unhook;
   154		}
   155	
   156		goto out;
   157	
   158	unhook:
   159		__kvmi_unhook(kvm);
   160	destroy:
   161		kvmi_destroy(kvmi);
   162	out:
   163		mutex_unlock(&kvm->kvmi_lock);
   164		return err;
   165	}
   166	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization