On Fri, Oct 09, 2020 at 02:41:26PM +0300, Dan Carpenter wrote: > Hi Mike, > > url: https://github.com/0day-ci/linux/commits/Mike-Christie/vhost-fix-scsi-cmd-handling-and-IOPs/20201008-045802 > base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next > config: x86_64-randconfig-m001-20201008 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > New smatch warnings: > drivers/vhost/vdpa.c:844 vhost_vdpa_open() error: uninitialized symbol 'r'. > > Old smatch warnings: > drivers/vhost/vdpa.c:436 vhost_vdpa_unlocked_ioctl() warn: maybe return -EFAULT instead of the bytes remaining? > drivers/vhost/vdpa.c:489 vhost_vdpa_unlocked_ioctl() warn: maybe return -EFAULT instead of the bytes remaining? > > vim +/r +844 drivers/vhost/vdpa.c > > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 793 static int vhost_vdpa_open(struct inode *inode, struct file *filep) > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 794 { > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 795 struct vhost_vdpa *v; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 796 struct vhost_dev *dev; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 797 struct vhost_virtqueue **vqs; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 798 int nvqs, i, r, opened; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 799 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 800 v = container_of(inode->i_cdev, struct vhost_vdpa, cdev); > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 801 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 802 opened = atomic_cmpxchg(&v->opened, 0, 1); > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 803 if (opened) > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 804 return -EBUSY; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 805 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 806 nvqs = v->nvqs; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 807 vhost_vdpa_reset(v); > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 808 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 809 vqs = kmalloc_array(nvqs, sizeof(*vqs), GFP_KERNEL); > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 810 if (!vqs) { > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 811 r = -ENOMEM; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 812 goto err; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 813 } > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 814 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 815 dev = &v->vdev; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 816 for (i = 0; i < nvqs; i++) { > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 817 vqs[i] = &v->vqs[i]; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 818 vqs[i]->handle_kick = handle_vq_kick; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 819 } > 7dc4d1082d406f3 Mike Christie 2020-10-07 820 if (vhost_dev_init(dev, vqs, nvqs, 0, 0, 0, false, > 7dc4d1082d406f3 Mike Christie 2020-10-07 821 vhost_vdpa_process_iotlb_msg)) > 7dc4d1082d406f3 Mike Christie 2020-10-07 822 goto err_dev_init; > > "r" not set on this error path. > > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 823 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 824 dev->iotlb = vhost_iotlb_alloc(0, 0); > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 825 if (!dev->iotlb) { > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 826 r = -ENOMEM; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 827 goto err_init_iotlb; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 828 } > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 829 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 830 r = vhost_vdpa_alloc_domain(v); > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 831 if (r) > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 832 goto err_init_iotlb; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 833 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 834 filep->private_data = v; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 835 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 836 return 0; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 837 > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 838 err_init_iotlb: > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 839 vhost_dev_cleanup(&v->vdev); > 7dc4d1082d406f3 Mike Christie 2020-10-07 840 err_dev_init: > 37787e9f81e2e58 Mike Christie 2020-09-21 841 kfree(vqs); > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 842 err: > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 843 atomic_dec(&v->opened); > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 @844 return r; > 4c8cf31885f69e8 Tiwei Bie 2020-03-26 845 } Yes looks like it would use r uninitialized ... Mike? > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
