Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver
From: "Deng, Jie" <jie.deng@xxxxxxxxx>
Date: Wed, 23 Sep 2020 07:34:35 +0000
Accept-language: en-US
Cc: "Sergey.Semin@xxxxxxxxxxxxxxxxxxxx" <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>, "bjorn.andersson@xxxxxxxxxx" <bjorn.andersson@xxxxxxxxxx>, "loic.poulain@xxxxxxxxxx" <loic.poulain@xxxxxxxxxx>, "Wang, Yu1" <yu1.wang@xxxxxxxxx>, "mst@xxxxxxxxxx" <mst@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "krzk@xxxxxxxxxx" <krzk@xxxxxxxxxx>, "virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx" <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "wsa@xxxxxxxxxx" <wsa@xxxxxxxxxx>, "wsa+renesas@xxxxxxxxxxxxxxxxxxxx" <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>, "jarkko.nikula@xxxxxxxxxxxxxxx" <jarkko.nikula@xxxxxxxxxxxxxxx>, "linux-i2c@xxxxxxxxxxxxxxx" <linux-i2c@xxxxxxxxxxxxxxx>, "rppt@xxxxxxxxxx" <rppt@xxxxxxxxxx>, "Liu, Shuo A" <shuo.a.liu@xxxxxxxxx>, "tali.perry1@xxxxxxxxx" <tali.perry1@xxxxxxxxx>, "Chen, Conghui" <conghui.chen@xxxxxxxxx>, "jdelvare@xxxxxxx" <jdelvare@xxxxxxx>
Dlp-product: dlpe-windows
Dlp-reaction: no-action
Dlp-version: 11.5.1.3
In-reply-to: <20200922112348.GL3956970@smile.fi.intel.com>
Ironport-sdr: SnPwnt2Zh9Dm65La51d4vrvxF9lPXoNqXDEumMWt4Oc0MRhvpUW7bGkdLuqjc1zFzsM2u2H1w7 XN4bBqzh1rPg==
Ironport-sdr: wzDSoWEkVoKPEu3Rce9V83/EOWsdcc3nubpW7GxOl+mO80/8Kdv0aoZ6CNiy+dP6VwcL7H6TMW mJ53VVEvcYdw==
References: <1350309657ab0c7b9f97e7a5c71d084f88caa549.1600743079.git.jie.deng@intel.com> <20200922112348.GL3956970@smile.fi.intel.com>

On 2020/9/22 19:23, Andy Shevchenko wrote:

+          if ((!vmsg) || (vmsg != &vi->vmsg)) {

This is a bit difficult to read (esp. taking into account the above comment)

besides the fact of redundant parentheses. Why not simply:

         if (!(vmsg && vmsg == &vi->vmsg)) {

Thanks Andy. It looks better.

--

2.7.4

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

References:
- [PATCH v3] i2c: virtio: add a virtio i2c frontend driver
  - From: Jie Deng
- Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver
Next by Date: Re: [PATCH 3/8] vhost scsi: alloc cmds per vq instead of session
Previous by thread: Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver
Next by thread: Re: [PATCH v3] i2c: virtio: add a virtio i2c frontend driver
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]