On Thu, Jul 02, 2020 at 05:48:33PM +1000, Nicholas Piggin wrote: > There is no need for rmb(), this allows faster lwsync here. Since you determined this; I'm thinking you actually understand the ordering here. How about recording this understanding in a comment? Also, should the lock->slock load not use READ_ONCE() ? _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization