Re: [PATCH net-next 2/2] virtio-net: fix the XDP truesize calculation for mergeable buffers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2020/5/6 下午3:37, Michael S. Tsirkin wrote:
On Wed, May 06, 2020 at 02:16:33PM +0800, Jason Wang wrote:
We should not exclude headroom and tailroom when XDP is set. So this
patch fixes this by initializing the truesize from PAGE_SIZE when XDP
is set.

Cc: Jesper Dangaard Brouer<brouer@xxxxxxxxxx>
Signed-off-by: Jason Wang<jasowang@xxxxxxxxxx>
Seems too aggressive, we do not use up the whole page for the size.




For XDP yes, we do:

static unsigned int get_mergeable_buf_len(struct receive_queue *rq,
                      struct ewma_pkt_len *avg_pkt_len,
                      unsigned int room)
{
    const size_t hdr_len = sizeof(struct virtio_net_hdr_mrg_rxbuf);
    unsigned int len;

    if (room)
        return PAGE_SIZE - room;

...

Thanks

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization




[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux