On Mon, Apr 06, 2020 at 05:56:02PM +0200, Greg Kroah-Hartman wrote: > On Mon, Apr 06, 2020 at 11:35:23AM -0400, Michael S. Tsirkin wrote: > > struct vring (in the uapi directory) and supporting APIs are kept > > around to avoid breaking old userspace builds. > > It's not actually part of the UAPI - it was kept in the UAPI > > header by mistake, and using it in kernel isn't necessary > > and prevents us from making changes safely. > > In particular, the APIs actually assume the legacy layout. > > > > Add struct vring_s (identical ATM) and supporting > > legacy APIs and switch everyone to use that. > > How are we going to know that "struct vring_s" is what we need/want to > use? What does "_s" mean? > > "struct vring_kernel"? > > naming is hard... > > greg k-h Hmm. I guess I can just add an ifdef so kernel doesn't see the UAPI version anymore ... -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
