Re: [PATCH -next] vdpasim: Rerun status in vdpasim_get_status

[Jason Wang <jasowang@xxxxxxxxxx>]

On 2020/3/31 上午11:35, YueHaibing wrote:
> vdpasim->status should acquired under spin lock.
>
> Fixes: 870448c31775 ("vdpasim: vDPA device simulator")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>   drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c b/drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c
> index 6e8a0cf2fdeb..72863d01a12a 100644
> --- a/drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/virtio/vdpa/vdpa_sim/vdpa_sim.c
> @@ -488,7 +488,7 @@ static u8 vdpasim_get_status(struct vdpa_device *vdpa)
>   	status = vdpasim->status;
>   	spin_unlock(&vdpasim->lock);
>   
> -	return vdpasim->status;
> +	return status;
>   }
>   
>   static void vdpasim_set_status(struct vdpa_device *vdpa, u8 status)


Typo in the title but patch looks good.

Acked-by: Jason Wang <jasowang@xxxxxxxxxx>

Thanks


_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization