On Tue, Mar 03, 2020 at 08:49:34AM +0100, Gerd Hoffmann wrote:
> > @@ -575,9 +574,12 @@ static int cirrus_pci_probe(struct pci_dev *pdev,
> >
> > dev = &cirrus->dev;
> > ret = drm_dev_init(dev, &cirrus_driver, &pdev->dev);
> > - if (ret)
> > - goto err_free_cirrus;
> > + if (ret) {
> > + kfree(cirrus);
> > + goto err_pci_release;
> > + }
> > dev->dev_private = cirrus;
> > + drmm_add_final_kfree(dev, cirrus);
>
> That doesn't look like an error path improvement.
> With patch #30 applied it'll looks alot better though.
> So maybe squash the patches?
Breaks the patch set evolution, there's a _lot_ of dependencies in here to
make sure we never break anything interim. But yeah that's why I created
this entire series, since with just the first part it's really not any
better. I also have a pile more ideas on top, so hopefully once this lands
I can get around to them and make everything even better :-)
Cheers, Daniel
>
> In any case:
> Acked-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
>
> cheers,
> Gerd
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
