>>> I would say reverting probably makes sense. I'm not sure there is much >>> value to having a shrinker running deflation when you are actively trying >>> to increase the balloon. It would make more sense to wait until you are >>> actually about to start hitting oom. >> >> I think the shrinker makes sense for free page hinting feature >> (everything on free_page_list). >> >> So instead of only reverting, I think we should split it up and always >> register the shrinker for VIRTIO_BALLOON_F_FREE_PAGE_HINT and the OOM >> notifier (as before) for VIRTIO_BALLOON_F_MUST_TELL_HOST. s/VIRTIO_BALLOON_F_MUST_TELL_HOST/VIRTIO_BALLOON_F_DEFLATE_ON_OOM/ :) >> >> (Of course, adapting what is being done in the shrinker and in the OOM >> notifier) > > David, > > Please keep me posted. I decided to adapt the same solution as the virtio > balloon for the VMware balloon. If the verdict is that this is damaging and > the OOM notifier should be used instead, I will submit patches to move to > OOM notifier as well. Will do. It all sounds sub-optimal to me at this point ... but I prefer the old variant where a simple "drop_slab()" won't deflate the balloon. That looks broken to me. -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
