On Fri, Jan 10, 2020 at 02:33:28AM +0100, Marek Marczykowski-Górecki wrote: > Hi, > > It looks like bochs_kms_fini() don't like being called if > bochs_kms_init() wasn't. Regardless of the reason for the > bochs_hw_init() failure (that's another story), it shouldn't cause a > panic. Any idea how to fix it? maybe this? diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index 3f0006c2470d..322be68a238a 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs/bochs_kms.c @@ -192,6 +192,9 @@ int bochs_kms_init(struct bochs_device *bochs) void bochs_kms_fini(struct bochs_device *bochs) { + if (!dev->mode_config.num_connector) + return; + drm_atomic_helper_shutdown(bochs->dev); drm_mode_config_cleanup(bochs->dev); } _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization