On 12/18/2019 03:06 AM, Daniel Verkamp wrote:
Ensure that elements of the array that correspond to unavailable
features are set to NULL; previously, they would be left uninitialized.
Since the corresponding names array elements were explicitly set to
NULL, the uninitialized callback pointers would not actually be
dereferenced; however, the uninitialized callbacks elements would still
be read in vp_find_vqs_msix() and used to calculate the number of MSI-X
vectors required.
With your 2nd patch:
if (names[i] && callbacks[i])
++nvectors;
It seems this patch isn't necessary as names[i] is already NULL, isn't it?
Best,
Wei
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
