On Tue, Sep 03, 2019 at 04:31:38AM -0400, Michael S. Tsirkin wrote: [..] > + /* TODO lock */ > give me pause. > > Cleanup generally seems broken to me - what pauses the FS I am looking into device removal aspect of it now. Thinking of adding a reference count to virtiofs device and possibly also a bit flag to indicate if device is still alive. That way, we should be able to cleanup device more gracefully. > > What about the rest of TODOs in that file? I will also take a closer look at TODOs now. Better device cleanup path might get rid of some of them. Some of them might not be valid anymore. > > use of usleep is hacky - can't we do better e.g. with a > completion? Agreed. Thanks Vivek _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
