On Wed, Jul 10, 2019 at 11:28:32PM +0530, Pankaj Gupta wrote:
> This patch fixes below sparse warning related to __virtio
> type in virtio pmem driver. This is reported by Intel test
> bot on linux-next tree.
>
> nd_virtio.c:56:28: warning: incorrect type in assignment
> (different base types)
> nd_virtio.c:56:28: expected unsigned int [unsigned] [usertype] type
> nd_virtio.c:56:28: got restricted __virtio32
> nd_virtio.c:93:59: warning: incorrect type in argument 2
> (different base types)
> nd_virtio.c:93:59: expected restricted __virtio32 [usertype] val
> nd_virtio.c:93:59: got unsigned int [unsigned] [usertype] ret
>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Pankaj Gupta <pagupta@xxxxxxxxxx>
> ---
>
> This fixes a warning, so submitting it as a separate
> patch on top of virtio pmem series.
>
> include/uapi/linux/virtio_pmem.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/linux/virtio_pmem.h b/include/uapi/linux/virtio_pmem.h
> index efcd72f2d20d..7a7435281362 100644
> --- a/include/uapi/linux/virtio_pmem.h
> +++ b/include/uapi/linux/virtio_pmem.h
> @@ -10,7 +10,7 @@
> #ifndef _UAPI_LINUX_VIRTIO_PMEM_H
> #define _UAPI_LINUX_VIRTIO_PMEM_H
>
> -#include <linux/types.h>
> +#include <linux/virtio_types.h>
> #include <linux/virtio_ids.h>
> #include <linux/virtio_config.h>
>
> @@ -23,12 +23,12 @@ struct virtio_pmem_config {
>
> struct virtio_pmem_resp {
> /* Host return status corresponding to flush request */
> - __u32 ret;
> + __virtio32 ret;
> };
>
> struct virtio_pmem_req {
> /* command type */
> - __u32 type;
> + __virtio32 type;
> };
>
> #endif
Same comment as previously: pls use __le and fix accessors.
> --
> 2.20.1
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
