Re: [PATCH v2 net 7/7] virtio_net: Differentiate sk_buff and xdp_frame on freeing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2019/1/29 上午10:35, Toshiaki Makita wrote:
On 2019/01/29 11:23, Jason Wang wrote:
On 2019/1/29 上午8:45, Toshiaki Makita wrote:
...
@@ -2666,10 +2696,10 @@ static void free_unused_bufs(struct
virtnet_info *vi)
       for (i = 0; i < vi->max_queue_pairs; i++) {
           struct virtqueue *vq = vi->sq[i].vq;
           while ((buf = virtqueue_detach_unused_buf(vq)) != NULL) {
-            if (!is_xdp_raw_buffer_queue(vi, i))
+            if (!is_xdp_frame(buf))

I believe this is the last user of is_xdp_raw_buffer_queue(), maybe you
can sent a patch on top to remove it.
Actually patch2 added new users of it ;)


Right, I missed that.

Thanks




                   dev_kfree_skb(buf);
               else
-                xdp_return_frame(buf);
+                xdp_return_frame(ptr_to_xdp(buf));
           }
       }

Acked-by: Jason Wang <jasowang@xxxxxxxxxx>

Thanks!

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization




[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux