From: jiangyiwen <jiangyiwen@xxxxxxxxxx>
Date: Wed, 12 Dec 2018 17:28:16 +0800
> +static int fill_mergeable_rx_buff(struct virtio_vsock *vsock,
> + struct virtqueue *vq)
> +{
> + struct page_frag *alloc_frag = &vsock->alloc_frag;
> + struct scatterlist sg;
> + /* Currently we don't use ewma len, use PAGE_SIZE instead, because too
> + * small size can't fill one full packet, sadly we only 128 vq num now.
> + */
> + unsigned int len = PAGE_SIZE, hole;
> + void *buf;
> + int err;
Please don't break up a set of local variable declarations with a
comment like this. The comment seems to be about the initialization
of 'len', so move that initialization into the code below the variable
declarations and bring the comment along for the ride as well.
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
