On Wed, Nov 21, 2018 at 09:54:22AM +0100, Gerd Hoffmann wrote: > On Tue, Oct 30, 2018 at 10:38:04AM +0100, Daniel Vetter wrote: > > On Tue, Oct 30, 2018 at 07:32:06AM +0100, Gerd Hoffmann wrote: > > > linux guest driver implementation of the VIRTIO_GPU_F_EDID feature. > > > > > > Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> > > > > Like with bochs, I think drm_do_get_edid() here is overkill and fairly > > pointless. > > Like with bochs it makes sense to use drm_do_get_edid(), because it > handles edid override and other common stuff. Not that this should > actually be needed for virtual devices, but I think it still makes sense > for consistency with other drivers, and it might be handy for testing > too. Yeah Jani corrected me here, I forgot that we reworked all this quite a bit. I checked the kerneldoc, it's up-to-date, so all good. Ack: me fwiw. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
