On Thu, 2018-05-24 at 06:47 -0600, Jens Axboe wrote: > On 5/23/18 4:35 PM, Joe Perches wrote: > > On Wed, 2018-05-23 at 15:27 -0600, Jens Axboe wrote: > > > On 5/23/18 2:05 PM, Joe Perches wrote: > > > > Convert the S_<FOO> symbolic permissions to their octal equivalents as > > > > using octal and not symbolic permissions is preferred by many as more > > > > readable. > > > > > > > > see: https://lkml.org/lkml/2016/8/2/1945 > > > > > > > > Done with automated conversion via: > > > > $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace <files...> > > > > > > > > Miscellanea: > > > > > > > > o Wrapped modified multi-line calls to a single line where appropriate > > > > o Realign modified multi-line calls to open parenthesis > > > > > > Honestly, I see this as pretty needless churn. > > > > btw: > > > > There is currently a mixture of symbolic and octal > > permissions uses in block and drivers/block > > > > ie: 94 octal and 146 symbolic uses. > > > > If this is applied, all would become octal. > > That does help justify the change. My main worry here is creating > unnecessary conflicts, which is always annoying. But it's even more > annoying when the change creating the conflict isn't really that > important at all. Case in point, the patch doesn't apply to the > for-4.18/block branch that it should go into... Done against most recent -next as it's basically impossible to do anything against multiple private trees. Also, the script that generated the patch is in the changelog so it's simple to rerun. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
