Hi Sridhar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net/master] [also build test WARNING on v4.17-rc1] [cannot apply to net-next/master next-20180420] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sridhar-Samudrala/Enable-virtio_net-to-act-as-a-standby-for-a-passthru-device/20180422-210557 config: i386-randconfig-a1-04221429 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): In file included from drivers//net/virtio_net.c:37:0: include/net/failover.h:67:1: error: expected identifier or '(' before '{' token { ^ >> include/net/failover.h:78:16: warning: 'struct pfailover' declared inside parameter list struct pfailover **pfailover); ^ >> include/net/failover.h:78:16: warning: its scope is only this definition or declaration, which is probably not what you want include/net/failover.h:79:1: error: expected identifier or '(' before '{' token { ^ include/net/failover.h:65:5: warning: 'failover_create' used but never defined int failover_create(struct net_device *standby_dev, ^ include/net/failover.h:77:5: warning: 'failover_register' declared 'static' but never defined [-Wunused-function] int failover_register(struct net_device *standby_dev, struct failover_ops *ops, ^ vim +78 include/net/failover.h 891cac68 Sridhar Samudrala 2018-04-19 63 891cac68 Sridhar Samudrala 2018-04-19 64 static inline 891cac68 Sridhar Samudrala 2018-04-19 65 int failover_create(struct net_device *standby_dev, 891cac68 Sridhar Samudrala 2018-04-19 66 struct failover **pfailover); 891cac68 Sridhar Samudrala 2018-04-19 @67 { 891cac68 Sridhar Samudrala 2018-04-19 68 return 0; 891cac68 Sridhar Samudrala 2018-04-19 69 } 891cac68 Sridhar Samudrala 2018-04-19 70 891cac68 Sridhar Samudrala 2018-04-19 71 static inline 891cac68 Sridhar Samudrala 2018-04-19 72 void failover_destroy(struct failover *failover) 891cac68 Sridhar Samudrala 2018-04-19 73 { 891cac68 Sridhar Samudrala 2018-04-19 74 } 891cac68 Sridhar Samudrala 2018-04-19 75 891cac68 Sridhar Samudrala 2018-04-19 76 static inline 891cac68 Sridhar Samudrala 2018-04-19 77 int failover_register(struct net_device *standby_dev, struct failover_ops *ops, 891cac68 Sridhar Samudrala 2018-04-19 @78 struct pfailover **pfailover); 891cac68 Sridhar Samudrala 2018-04-19 79 { 891cac68 Sridhar Samudrala 2018-04-19 80 return 0; 891cac68 Sridhar Samudrala 2018-04-19 81 } 891cac68 Sridhar Samudrala 2018-04-19 82 :::::: The code at line 78 was first introduced by commit :::::: 891cac68e9283c9561d0097af77e7189b9752719 net: Introduce generic failover module :::::: TO: Sridhar Samudrala <sridhar.samudrala@xxxxxxxxx> :::::: CC: 0day robot <fengguang.wu@xxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
