Hi, I have a concern about the portability of offloading the new VIRTIO packed ring format to hardware. According to the PCIe rev 2.0, paragraph 2.4.2. Update Ordering and Granularity Observed by a Read Transaction" " if a host CPU writes a QWORD to host memory, a Requester reading that QWORD from host memory may observe a portion of the QWORD updated and another portion of it containing the old value." This means that after the device reads a 16byte descriptor, it cannot know that all the values In the descriptor are up to date even if the VIRTQ_DESC_F_AVAIL bit is set. This is true even if the driver uses the appropriate memory barriers. We encountered this behavior in practice on x86 servers. Our solution was to add an index to the latest valid descriptor Note that in practice the update granularity in x86 seems to be a cacheline, But this is not guaranteed by the spec. The spec only makes the following recommendation: "While not required by this specification, it is strongly recommended that host platforms guarantee that when a host CPU writes aligned DWORDs or aligned QWORDs to host memory, the update granularity observed by a PCI Express read will not be smaller than a DWORD." Thanks, Ilya _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
