Re: [PATCH net-next] virtio_net: Add ethtool stats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 20 Dec 2017 13:40:37 +0900
Toshiaki Makita <makita.toshiaki@xxxxxxxxxxxxx> wrote:

> +
> +static const struct virtnet_gstats virtnet_gstrings_stats[] = {
> +	{ "rx_packets",		VIRTNET_NETDEV_STAT(rx_packets) },
> +	{ "tx_packets",		VIRTNET_NETDEV_STAT(tx_packets) },
> +	{ "rx_bytes",		VIRTNET_NETDEV_STAT(rx_bytes) },
> +	{ "tx_bytes",		VIRTNET_NETDEV_STAT(tx_bytes) },
> +	{ "rx_dropped",		VIRTNET_NETDEV_STAT(rx_dropped) },
> +	{ "rx_length_errors",	VIRTNET_NETDEV_STAT(rx_length_errors) },
> +	{ "rx_frame_errors",	VIRTNET_NETDEV_STAT(rx_frame_errors) },
> +	{ "tx_dropped",		VIRTNET_NETDEV_STAT(tx_dropped) },
> +	{ "tx_fifo_errors",	VIRTNET_NETDEV_STAT(tx_fifo_errors) },
> +};
> +

Please do not merge pre-existing global stats into ethtool.
It just duplicates existing functionality.
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization



[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux