On Fri, Nov 03, 2017 at 04:13:02PM +0800, Wei Wang wrote: > From: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx> > > Add the following tests for xbitmap: > 1) single bit test: single bit set/clear/find; > 2) bit range test: set/clear a range of bits and find a 0 or 1 bit in > the range. > > Signed-off-by: Wei Wang <wei.w.wang@xxxxxxxxx> > Cc: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Cc: Michael S. Tsirkin <mst@xxxxxxxxxx> > --- > tools/include/linux/bitmap.h | 34 ++++ > tools/include/linux/kernel.h | 2 + > tools/testing/radix-tree/Makefile | 7 +- > tools/testing/radix-tree/linux/kernel.h | 2 - > tools/testing/radix-tree/main.c | 5 + > tools/testing/radix-tree/test.h | 1 + > tools/testing/radix-tree/xbitmap.c | 278 ++++++++++++++++++++++++++++++++ Umm. No. You've duplicated xbitmap.c into the test framework, so now it can slowly get out of sync with the one in lib/. That's not OK. Put it back the way it was, with the patch I gave you as patch 1/n (relocating xbitmap.c from tools/testing/radix-tree to lib/). Then add your enhancements as patch 2/n. All you should need to change in your 1/n from http://git.infradead.org/users/willy/linux-dax.git/commit/727e401bee5ad7d37e0077291d90cc17475c6392 is a bit of Makefile tooling. Leave the test suite embedded in the file; that way people might remember to update the test suite when adding new functionality. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
