On 08/07/2017 04:44 PM, David Hildenbrand wrote:
On 03.08.2017 13:59, Wei Wang wrote:This patch is a revert of 'commit bb01b64cfab7 ("mm/balloon_compaction.c: enqueue zero page to balloon device")' Ballooned pages will be marked as MADV_DONTNEED by the hypervisor and shouldn't be given to the host ksmd to scan. Therefore, it is not necessary to zero ballooned pages, which is very time consuming when the page amount is large. The ongoing fast balloon tests show that the time to balloon 7G pages is increased from ~491ms to 2.8 seconds with __GFP_ZERO added. So, this patch removes the flag. Signed-off-by: Wei Wang <wei.w.wang@xxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxxxxx> Cc: Michael S. Tsirkin <mst@xxxxxxxxxx> --- mm/balloon_compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/balloon_compaction.c b/mm/balloon_compaction.c index 9075aa5..b06d9fe 100644 --- a/mm/balloon_compaction.c +++ b/mm/balloon_compaction.c @@ -24,7 +24,7 @@ struct page *balloon_page_enqueue(struct balloon_dev_info *b_dev_info) { unsigned long flags; struct page *page = alloc_page(balloon_mapping_gfp_mask() | - __GFP_NOMEMALLOC | __GFP_NORETRY | __GFP_ZERO); + __GFP_NOMEMALLOC | __GFP_NORETRY); if (!page) return NULL;Your assumption here is, that the hypervisor will always supply a zero page. Unfortunately, this assumption is wrong (and it stems from the lack of different page size support in virtio-balloon).
I think this would be something that we can improve the balloon. For example, the balloon request from the device should be aligned to the host page size before sending to the guest driver: On PPC, if the command requests for 140K memory to inflate, it can be aligned to 128K.
Think about these examples: 1. Guest is backed by huge pages (hugetbfs). Ballooning kicks in. MADV_DONTNEED is simply ignored in the hypervisor (hugetlbfs requires fallocate punshhole). Also, trying to zap 4k on e.g. 1MB pages will simply be ignored.
For the hugetlbfs case, I think the balloon size can be aligned to the huge page size (i.e 2M or 1GB). Best, Wei _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
