On Mon 31-07-17 15:41:49, Wei Wang wrote: > On 07/31/2017 02:55 PM, Michal Hocko wrote: > >On Mon 31-07-17 12:13:33, Wei Wang wrote: > >>Ballooned pages will be marked as MADV_DONTNEED by the hypervisor and > >>shouldn't be given to the host ksmd to scan. > >Could you point me where this MADV_DONTNEED is done, please? > > Sure. It's done in the hypervisor when the balloon pages are received. > > Please see line 40 at > https://github.com/qemu/qemu/blob/master/hw/virtio/virtio-balloon.c And one more thing. I am not familiar with ksm much. But how is MADV_DONTNEED even helping? This madvise is not sticky - aka it will unmap the range without leaving any note behind. AFAICS the only way to have vma scanned is to have VM_MERGEABLE and that is an opt in: See Documentation/vm/ksm.txt " KSM only operates on those areas of address space which an application has advised to be likely candidates for merging, by using the madvise(2) system call: int madvise(addr, length, MADV_MERGEABLE). " So what exactly is going on here? The original patch looks highly suspicious as well. If somebody wants to make that memory mergable then the user of that memory should zero them out. -- Michal Hocko SUSE Labs _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
