On Wed, Jul 05, 2017 at 07:57:07AM +0000, Liu, Changpeng wrote: > > > > -----Original Message----- > > From: Paolo Bonzini [mailto:pbonzini@xxxxxxxxxx] > > Sent: Tuesday, July 4, 2017 5:24 PM > > To: Liu, Changpeng <changpeng.liu@xxxxxxxxx>; virtualization@lists.linux- > > foundation.org > > Cc: stefanha@xxxxxxxxx; hch@xxxxxx; mst@xxxxxxxxxx > > Subject: Re: [PATCH v2] virtio-blk: add DISCARD support to virtio-blk driver > > > > > > > > On 05/07/2017 10:44, Changpeng Liu wrote: > > > Currently virtio-blk driver does not provide discard feature flag, so the > > > filesystems which built on top of the block device will not send discard > > > command. This is okay for HDD backend, but it will impact the performance > > > for SSD backend. > > > > > > Add a feature flag VIRTIO_BLK_F_DISCARD and command > > VIRTIO_BLK_T_DISCARD > > > to extend exist virtio-blk protocol, define 16 bytes discard descriptor > > > for each discard segment, the discard segment defination aligns with > > > SCSI or NVM Express protocols, virtio-blk driver will support multi-range > > > discard request as well. > > > > > > Signed-off-by: Changpeng Liu <changpeng.liu@xxxxxxxxx> > > > > Please include a patch for the specification. Since we are at it, I > Thanks Paolo, do you mean include a text file which describe the changes for the specification? Paolo answered that. But please also CC code patch to virtio-comment@xxxxxxxxxxxxxxxxxxxx . This is a subscriber-only list so pls subscribe beforehand: https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio#feedback -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
