>> Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > > Please include an actual explanation for this change instead of linking > to slides. Do you care for a bit of code size reduction by removal of questionable error messages? > Why are you trying to get rid of memory allocation failure messages? Do you find information from a Linux allocation failure report sufficient for any function implementations here? >> +++ b/drivers/vhost/scsi.c >> @@ -417,5 +417,4 @@ vhost_scsi_allocate_evt(struct vhost_scsi *vs, >> if (!evt) { >> - vq_err(vq, "Failed to allocate vhost_scsi_evt\n"); > > #define vq_err(vq, fmt, ...) do { \ > pr_debug(pr_fmt(fmt), ##__VA_ARGS__); \ > if ((vq)->error_ctx) \ > eventfd_signal((vq)->error_ctx, 1);\ > } while (0) > > You silently dropped the eventfd_signal() call. Do you prefer to preserve this special error handling then? Regards, Markus _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
