From: Alex Williamson > Sent: 15 May 2017 04:21 ... > > > /* Find end of list, sew whole thing into vi->rq.pages. */ > > > - for (end = page; end->private; end = (struct page *)end->private); > > > + for (end = page; end->private; end = (struct page *)end->private) > > > + ; > > FWIW, I generally like to put a comment on the next line to make it > abundantly clear that there's nothing in the body of the loop, it's > also more aesthetically pleasing than a semi-colon on the line by > itself, ex. /* Nothing */; It's just too easy to misinterpret the > loop otherwise, especially without gratuitous white space. Thanks, My preference is to put 'continue;' on a line by itself. Or even move the termination condition into the loop: for (end = page;; end = (struct page *)end->private) if (!end->private) break; (oh, is that cast needed??) David _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
