On 2017年03月29日 18:46, Pankaj Gupta wrote:
Hi Jason,
On 2017年03月23日 13:34, Jason Wang wrote:
+{
+ if (rvq->rh != rvq->rt)
+ goto out;
+
+ rvq->rh = rvq->rt = 0;
+ rvq->rt = skb_array_consume_batched_bh(rvq->rx_array, rvq->rxq,
+ VHOST_RX_BATCH);
A comment explaining why is is -bh would be helpful.
Ok.
Thanks
Rethink about this. It looks like -bh is not needed in this case since
no consumer run in bh.
In that case do we need other variants of "ptr_ring_consume_batched_*()" functions.
Are we planning to use them in future?
I think we'd better keep them, since it serves as helpers. You can see
that not all the helpers in ptr_ring has real users, but they were
prepared for the future use.
Thanks
Thanks
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
