On 01.03.2017 04:30, Zbigniew Jędrzejewski-Szmek wrote: > On Tue, Feb 28, 2017 at 09:47:42AM +0100, Viktor Mihajlovski wrote: >>>>>> One could argue about back-level compatibility, but virtio by-path >>>>>> naming has changed multiple times. We have seen virtio-pci-virtio<n> >>>>>> (not predictable), pci-<busid> and virtio-pci-<busid> already. It >>>>>> might be a good time now to settle on a common approach for all >>>>>> virtio types. >>>>>> >>>>>> For the reasons above, I'd vote for <subsystem>-<busid>, which >>>>>> would work for PCI and CCW, not sure about ARM MMIO though. > > It seems that there's agreement that <subsystem>-<busid> is the right > approach. > > Ideally we would keep the virtio-pci-<busid> links as they appear > right now, for backwards compatibility, just for the pci devices, and > mark them as deprecated (dunno where, maybe just in NEWS), and add the > code to make the links. > > I haven't looked at the code, maybe we just do this with the right > udev rule, and also stick the deprecation comment there? > > Zbyszek > I've posted a github pull request [1], and would appreciate review feedback. As I am lacking an ARM setup, it would also be nice if someone with ARM skills could have a look as well. If wanted, I can take a stab at virtio-mmio, but would need the output of udevadm -a /dev/vda from a virtio-mmio system. [1] https://github.com/systemd/systemd/pull/5500 -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
