On 2017年01月01日 05:03, Stephen Hemminger wrote:
On Fri, 30 Dec 2016 13:20:51 +0800
Jason Wang <jasowang@xxxxxxxxxx> wrote:
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index cd8e02c..a268ed9 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -75,6 +75,10 @@
#include <linux/uaccess.h>
+static int rx_batched;
+module_param(rx_batched, int, 0444);
+MODULE_PARM_DESC(rx_batched, "Number of packets batched in rx");
+
/* Uncomment to enable debugging */
I like the concept or rx batching. But controlling it via a module parameter
is one of the worst API choices. Ethtool would be better to use because that is
how other network devices control batching.
If you do ethtool, you could even extend it to have an number of packets
and max latency value.
Right, this is better (I believe you mean rx-frames). For rx-usecs, we
could do it on top in the future.
Thanks
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
