On Wed, Dec 07, 2016 at 11:14:09PM +0800, Peng Tao wrote:
> So that we can cancel a queued pkt later if necessary.
>
> Signed-off-by: Peng Tao <bergwolf@xxxxxxxxx>
> ---
> include/linux/virtio_vsock.h | 2 ++
> net/vmw_vsock/virtio_transport_common.c | 7 +++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/linux/virtio_vsock.h b/include/linux/virtio_vsock.h
> index 9638bfe..6dd3242 100644
> --- a/include/linux/virtio_vsock.h
> +++ b/include/linux/virtio_vsock.h
> @@ -48,6 +48,7 @@ struct virtio_vsock_pkt {
> struct virtio_vsock_hdr hdr;
> struct work_struct work;
> struct list_head list;
> + struct vsock_sock *vsk;
To prevent future bugs, please add a comment here:
/* socket refcnt not held, only use for cancellation */
This field is just an opaque token used for cancellation rather than a
struct vsock_sock pointer that we are allowed to dereference. You could
change this field to void *cancel_token to make the code harder to
misuse.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
