>> Adjust a jump label according to the current Linux coding style convention. > > I think you mean "goto label". "Jump label" has a different meaning, > see <linux/jump_label.h>. Does a "goto" statement jump to the code position finally which is specified by the label? >> @@ -247,10 +247,10 @@ static int virtblk_get_id(struct gendisk *disk, char *id_str) >> >> err = blk_rq_map_kern(q, req, id_str, VIRTIO_BLK_ID_BYTES, GFP_KERNEL); >> if (err) >> - goto out; >> + goto put_request; >> >> err = blk_execute_rq(vblk->disk->queue, vblk->disk, req, false); >> -out: >> + put_request: > > I checked Documentation/CodingStyle and see no reason to rename the label. Can the suggested longer identifier explain better the "what" and "why" for this software situation? > It's also not clear why you added a space. The CodingStyle example > does not use a space before the label. Do you find information from a commit like "docs: Remove space-before-label guidance from CodingStyle" (from 2016-09-21) interesting? ;-) https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/Documentation/CodingStyle?id=79c70c304b0b443429b2a0019518532c5162817a Regards, Markus _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
