On Fri, Apr 08, 2016 at 08:58:44PM +0200, Denys Vlasenko wrote: > This function compiles to 839 bytes of machine code. > In C, it is ~150 lines long. > > This function has 3 callsites. > > Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx> > CC: "Michael S. Tsirkin" <mst@xxxxxxxxxx> > CC: virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx > CC: linux-kernel@xxxxxxxxxxxxxxx This function is one of the most performance critical ones in the driver, a bunch of tuning went into it, making this inline intentionally. I'd have to see some numbers showing making it non-inline is a worth-while tradeoff. > --- > drivers/virtio/virtio_ring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index e12e385..77a4771 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -126,7 +126,7 @@ static struct vring_desc *alloc_indirect(struct virtqueue *_vq, > return desc; > } > > -static inline int virtqueue_add(struct virtqueue *_vq, > +static int virtqueue_add(struct virtqueue *_vq, > struct scatterlist *sgs[], > unsigned int total_sg, > unsigned int out_sgs, > -- > 2.1.0 _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
