On Wed, Dec 17, 2014 at 08:03:10AM +1100, Herbert Xu wrote: > Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > > Move everything dealing with legacy devices out to virtio_pci_legacy.c. > > Expose common code APIs in virtio_pci.h > > > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > This breaks virtio_pci because you deleted the licence from it. > > -- >8 -- > Subject: virtio_pci: Restore module licence and other attributes > > When the virtio_pci driver was moved into virtio_pci_legacy.c the > module licence and other attributes went AWOL. This patch restores > them. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Thanks! I'll apply a similar patch but to virtio_pci_common. Will send a pull request with this included tomorrow. > diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c > index 2588252..6b100e3 100644 > --- a/drivers/virtio/virtio_pci_legacy.c > +++ b/drivers/virtio/virtio_pci_legacy.c > @@ -324,3 +324,8 @@ static struct pci_driver virtio_pci_driver = { > }; > > module_pci_driver(virtio_pci_driver); > + > +MODULE_AUTHOR("Anthony Liguori <aliguori@xxxxxxxxxx>"); > +MODULE_DESCRIPTION("virtio-pci"); > +MODULE_LICENSE("GPL"); > +MODULE_VERSION("1"); > > Cheers, > -- > Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization