On Thu, 11 Dec 2014 14:25:05 +0100
Cornelia Huck <cornelia.huck@xxxxxxxxxx> wrote:
> Add virtio_{add,clear}_feature helper functions for manipulating a
> feature bits variable. This has some benefits over open coding:
> - add check that the bit is in a sane range
> - make it obvious at a glance what is going on
> - have a central point to change when we want to extend feature bits
>
> Convert existing code manipulating features to use the new helpers.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>
> ---
> hw/9pfs/virtio-9p-device.c | 2 +-
> hw/block/virtio-blk.c | 16 ++++++++--------
> hw/char/virtio-serial-bus.c | 2 +-
> hw/net/virtio-net.c | 34 +++++++++++++++++-----------------
> hw/s390x/virtio-ccw.c | 4 ++--
> hw/virtio/virtio-mmio.c | 2 +-
> hw/virtio/virtio-pci.c | 4 ++--
> include/hw/virtio/virtio.h | 12 ++++++++++++
> 8 files changed, 44 insertions(+), 32 deletions(-)
Patch looks fine to me.
Reviewed-by: Thomas Huth <thuth@xxxxxxxxxxxxxxxxxx>
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
