On Thu, Nov 27, 2014 at 04:16:36PM +0100, Cornelia Huck wrote: > With virtio-1, we support more than 32 feature bits. Let's make > vdev->guest_features depend on the number of supported feature bits, > allowing us to grow the feature bits automatically. > > We also need to enhance the internal functions dealing with getting > and setting features with an additional index field, so that all feature > bits may be accessed (in chunks of 32 bits). > > vhost and migration have been ignored for now. > > Reviewed-by: Thomas Huth <thuth@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx> > @@ -117,7 +125,7 @@ struct VirtIODevice > uint8_t status; > uint8_t isr; > uint16_t queue_sel; > - uint32_t guest_features; > + uint32_t guest_features[NR_VIRTIO_FEATURE_WORDS]; > size_t config_len; > void *config; > uint16_t config_vector; Ugh. That's quite tricky to use correctly. Why don't we just make it uint64_t? The only real issue is that DEFINE_PROP_BIT wants a uint32_t. But that's easy to fix: add DEFINE_PROP64_BIT that is the same but handles a 64 bit array. -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
