On 21 October 2014 03:09, Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx> wrote: > On Mon, Oct 20, 2014 at 10:05 AM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: >> On Mon, Oct 20, 2014 at 03:58:49PM +0200, Cornelia Huck wrote: >>> Commit f5866db6 (virtio_console: enable VQs early) tried to make >>> sure that DRIVER_OK was set when virtio_console started using its >>> virtqueues. Doing this in add_port(), however, means that we try >>> to set DRIVER_OK again when when a port is dynamically added after >>> the probe function is done. >>> >>> Let's move virtio_device_ready() to the probe function just before >>> trying to use the virtqueues instead. This is fine as nothing can >>> fail inbetween. >>> >>> Reported-by: Thomas Graf <tgraf@xxxxxxx> >>> Reviewed-by: Michael S. Tsirkin <mst@xxxxxxxxxx> >>> Signed-off-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx> >> >> Thanks! >> >> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> >> Tested-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > This fixed my KVM guest boot issue with 3.18-rc1. Thanks for such a quick fix. > > Tested-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx> ping So who's merging this? Rusty? still happens in -rc4. Dave. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
