On (Tue) 07 Oct 2014 [15:53:55], Michael S. Tsirkin wrote: > On Mon, Oct 06, 2014 at 06:10:40PM +0300, Michael S. Tsirkin wrote: > > On restore, virtio pci does the following: > > + set features > > + init vqs etc - device can be used at this point! > > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits > > > > This is in violation of the virtio spec, which > > requires the following order: > > - ACKNOWLEDGE > > - DRIVER > > - init vqs > > - DRIVER_OK > > > > This behaviour will break with hypervisors that assume spec compliant > > behaviour. It seems like a good idea to have this patch applied to > > stable branches to reduce the support butden for the hypervisors. > > Tested suspend to ram with virtio net and blk. I'd recommend running a continuous ping for virtio-net and a dd process running across s3/s4 for testing. That's what I had run while doing the original set of patches. Amit _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
