On Mon, Sep 15, 2014 at 12:40:07PM +0200, Gerd Hoffmann wrote:
> > > > > +
> > > > > +enum virtgpu_ctrl_type {
> > > > > + VIRTGPU_UNDEFINED = 0,
> > > > > +
> > > > > + /* 2d commands */
> > > > > + VIRTGPU_CMD_GET_DISPLAY_INFO = 0x0100,
> > > >
> > > > Please consider also adding:
> >
> > VIRTIO_GPU_ everywhere to make it consistent with other
> > virtio headers?
>
> The names are already pretty long as-is, especially considering the
> 80cols rule in our codestyle. I'd prefer to keep them the way they are
> now.
>
> cheers,
> Gerd
>
VIRTIO_GPU_ is not longer than VIRTIO_NET_ is it?
VIRTGRU seems too generic.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
