From: Jason Wang <jasowang@xxxxxxxxxx> Date: Wed, 26 Mar 2014 13:03:00 +0800 > Current error handling of virtqueue_kick() was wrong in two places: > - The skb were freed immediately when virtqueue_kick() fail during > xmit. This may lead double free since the skb was not detached from > the virtqueue. > - try_fill_recv() returns false when virtqueue_kick() fail. This will > lead unnecessary rescheduling of refill work. > > Actually, it's safe to just ignore the kick failure in those two > places. So this patch fixes this by partially revert commit > 67975901183799af8e93ec60e322f9e2a1940b9b. > > Fixes 67975901183799af8e93ec60e322f9e2a1940b9b > (virtio_net: verify if virtqueue_kick() succeeded). > > Cc: Heinz Graalfs <graalfs@xxxxxxxxxxxxxxxxxx> > Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx> > Cc: Michael S. Tsirkin <mst@xxxxxxxxxx> > Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx> Applied and queued up for -stable, thanks. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
