Hi Eric, Michael, On Wed, Jan 8, 2014 at 11:16 AM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > Why should we select a frame at random and make it's truesize bigger? > All frames are to blame for the extra space. > Just ignoring it seems more symmetrical. Sounds good, based on Eric's feedback and Michael's feedback above, I will leave the 'extra space' handling as-is in the followup patchset and will not track the extra space in ctx->truesize. AFAICT, The two max() statements will need to remain (as buffer length may exceed ctx->truesize). Thanks for the feedback. > If you intend to repost anyway (for the below wrinkle) then > you can do it right here just as well I guess. Seems a bit prettier. Will do. > You don't have to fill in ctx before calling add_inbuf, do you? > Just fill it afterwards. Agreed, ctx does not need to be filled until after add_inbuf. Best, Mike _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
